On Sat, Jan 17, 2026 at 7:44 PM Krzysztof Kozlowski <[email protected]> wrote: > > On Fri, Jan 16, 2026 at 06:16:47PM +0800, Shengjiu Wang wrote: > > The specific feature for AUDMIX on i.MX952 is that it can be bypassed, > > so add fsl,amix-bypass property for this feature, besides this there is > > no power domain defined on i.MX952, so make power-domains to be > > dedicated to i.MX8QM. > > > > Signed-off-by: Shengjiu Wang <[email protected]> > > --- > > .../devicetree/bindings/sound/fsl,audmix.yaml | 35 +++++++++++++++++-- > > 1 file changed, 33 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,audmix.yaml > > b/Documentation/devicetree/bindings/sound/fsl,audmix.yaml > > index 3ad197b3c82c..50fb08460b4f 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl,audmix.yaml > > +++ b/Documentation/devicetree/bindings/sound/fsl,audmix.yaml > > @@ -34,7 +34,9 @@ description: | > > > > properties: > > compatible: > > - const: fsl,imx8qm-audmix > > + enum: > > + - fsl,imx8qm-audmix > > + - fsl,imx952-audmix > > > > reg: > > maxItems: 1 > > @@ -75,12 +77,41 @@ properties: > > unevaluatedProperties: false > > description: Output port to SAI RX > > > > + fsl,amix-bypass: > > + type: boolean > > + description: > > + The audmix module is bypassed from hardware. > > I don't understand why device AUDMIX would have property saying AUDMIX > (so itself) can by bypassed. If you bypass the device itself, what do > you configure here?
The case is that the SAI interface is connected to AUDMIX, but AUDMIX can also be bypassed by hardware configuration. Yes, adding this property in the AUDMIX module looks strange. Another choice is to add this property in the SAI binding document. Is this better? Best regards Shengjiu Wang > > > > + > > required: > > - compatible > > - reg > > - clocks > > - clock-names > > - - power-domains > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - fsl,imx8qm-audmix > > + then: > > + required: > > + - power-domains > > + not: > > + required: > > + - fsl,amix-bypass > > fsl,amix-bypass: false > > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - fsl,imx952-audmix > > + then: > > + not: > > + required: > > + - power-domains > > Not sure what you want to say here, but disallowing properties is shown > in example-schema (:false). > > Best regards, > Krzysztof >
