On Wed, Jan 21, 2026 at 4:03 PM Krzysztof Kozlowski <[email protected]> wrote:
>
> On Tue, Jan 20, 2026 at 11:52:08AM +0800, Shengjiu Wang wrote:
> > The SAI can connect to AUDMIX, but AUDMIX can be bypassed or not on
> > i.MX952, so add 'fsl,sai-amix-mode' property for this feature, with
> > this property present, then SAI driver will try to config the setting,
>
> I am still not sure this is hardware static property. You say "can be
> bypassed", so I imagine same board could have it bypassed or not,
> depending on use case (so mixers).
Yes, depending on the use case.
1. When bypassed, the SAI output goes to codec directly.
like: SAI -> Codec
2. AUDMIX mode: the SAI output goes to AUDMIX.
like: SAI -> AUDMIX-> Codec
Will add above info in the commit message.
>
> > fsl,sai-amix-mode = <0> is bypass mode, fsl,sai-amix-mode = <1> is
> > the AUDMIX mode.
> >
> > Signed-off-by: Shengjiu Wang <[email protected]>
> > ---
> > .../devicetree/bindings/sound/fsl,sai.yaml | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > index d838ee0b61cb..7808c324eebc 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > @@ -133,6 +133,13 @@ properties:
> > - description: dataline mask for 'rx'
> > - description: dataline mask for 'tx'
> >
> > + fsl,sai-amix-mode:
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> Anyway, string is more readable.
Ok, will use string
>
> > + description:
> > + The audmix module is bypassed from hardware or not.
> > + Bypass AUDMIX(0), AUDMIX mode(1)
>
> Drop last sentence and use enum [ bypass, mode-1-whatever-this-means ]
>
> > + enum: [0, 1]
>
> What is the default? What is the meaning of lack of this property?
>
fsl,sai-amix-mode:
$ref: /schemas/types.yaml#/definitions/string
description:
The audmix module is bypassed from hardware or not.
enum: [none, bypass, audmix]
default: none
I'd like to use the above definition. add 'none' for default.
Which means no audmix connection in hardware. then we don't need to
bypass or not-bypass audmix.
> > +
> > fsl,sai-mclk-direction-output:
> > description: SAI will output the SAI MCLK clock.
> > type: boolean
> > @@ -180,6 +187,15 @@ allOf:
> > properties:
> > fsl,sai-synchronous-rx: false
> >
> > + - if:
> > + required:
> > + - fsl,sai-amix-mode
> > + then:
> > + properties:
> > + compatible:
> > + contains:
> > + const: fsl,imx952-sai
>
> There is no such compatible.
It is in another patch:
https://www.spinics.net/lists/kernel/msg6004158.html
Best regards
Shengjiu Wang
>
> > +
> > required:
> > - compatible
> > - reg
> > --
> > 2.34.1
> >
