scnprintf("%*pbl") is more verbose than bitmap_print_to_pagebuf().
Switch the test to using it. This also improves the test output
because bitmap_print_to_pagebuf() adds \n at the end of the printed
bitmap, which breaks the test format.

Signed-off-by: Yury Norov <[email protected]>
---
The following patch adds more beautifications to the test outputs and
shows the before/after.

 lib/test_bitmap.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
index c83829ef557f..2d9b71ad455c 100644
--- a/lib/test_bitmap.c
+++ b/lib/test_bitmap.c
@@ -544,22 +544,22 @@ static void __init test_bitmap_printlist(void)
                goto out;
 
        time = ktime_get();
-       ret = bitmap_print_to_pagebuf(true, buf, bmap, PAGE_SIZE * 8);
+       ret = scnprintf(buf, PAGE_SIZE, "%*pbl", (int)PAGE_SIZE * 8, bmap);
        time = ktime_get() - time;
 
-       if (ret != slen + 1) {
-               pr_err("bitmap_print_to_pagebuf: result is %d, expected %d\n", 
ret, slen);
+       if (ret != slen) {
+               pr_err("bitmap_printlist: result is %d, expected %d\n", ret, 
slen);
                failed_tests++;
                goto out;
        }
 
        if (strncmp(buf, expected, slen)) {
-               pr_err("bitmap_print_to_pagebuf: result is %s, expected %s\n", 
buf, expected);
+               pr_err("bitmap_printlist: result is %s, expected %s\n", buf, 
expected);
                failed_tests++;
                goto out;
        }
 
-       pr_info("bitmap_print_to_pagebuf: input is '%s', Time: %llu\n", buf, 
time);
+       pr_info("bitmap_printlist: input is '%s', Time: %llu\n", buf, time);
 out:
        kfree(buf);
        kfree(bmap);
-- 
2.43.0


Reply via email to