On Thu, Mar 05, 2026 at 11:10:29AM +0800, Shengjiu Wang wrote:
> +int fsl_asoc_get_xr_sx(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
> + bool pm_active = pm_runtime_active(component->dev);
> +
> + if (!pm_active) {
> + ucontrol->value.integer.value[0] = 0;
> + return 0;
> + }
> +
> + return snd_soc_get_xr_sx(kcontrol, ucontrol);
> +}
This is racy, what happens if we race with runtime PM disabling the
device so it gets powered off between the check and the call to the
generic function? I think we need to take a runtime reference here,
this is annoying but I can't see how else to do things robustly and
probably in practice there's not much performance impact.
> +EXPORT_SYMBOL(fsl_asoc_get_xr_sx);
> +
> +int fsl_asoc_put_xr_sx(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
> + bool pm_active = pm_runtime_active(component->dev);
> +
> + if (!pm_active)
> + return 0;
> +
> + return snd_soc_put_xr_sx(kcontrol, ucontrol);
> +}
> +EXPORT_SYMBOL(fsl_asoc_put_xr_sx);
> +
> +int fsl_asoc_get_enum_double(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
> + bool pm_active = pm_runtime_active(component->dev);
> +
> + if (!pm_active) {
> + ucontrol->value.enumerated.item[0] = 0;
> + return 0;
> + }
> +
> + return snd_soc_get_enum_double(kcontrol, ucontrol);
> +}
> +EXPORT_SYMBOL(fsl_asoc_get_enum_double);
> +
> +int fsl_asoc_put_enum_double(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
> + bool pm_active = pm_runtime_active(component->dev);
> +
> + if (!pm_active)
> + return 0;
> +
> + return snd_soc_put_enum_double(kcontrol, ucontrol);
> +}
> +EXPORT_SYMBOL(fsl_asoc_put_enum_double);
> +
> +int fsl_asoc_get_volsw(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
> + bool pm_active = pm_runtime_active(component->dev);
> +
> + if (!pm_active) {
> + ucontrol->value.integer.value[0] = 0;
> + return 0;
> + }
> +
> + return snd_soc_get_volsw(kcontrol, ucontrol);
> +}
> +EXPORT_SYMBOL(fsl_asoc_get_volsw);
> +
> +int fsl_asoc_put_volsw(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
> + bool pm_active = pm_runtime_active(component->dev);
> +
> + if (!pm_active)
> + return 0;
> +
> + return snd_soc_put_volsw(kcontrol, ucontrol);
> +}
> +EXPORT_SYMBOL(fsl_asoc_put_volsw);
> +
> MODULE_AUTHOR("Timur Tabi <[email protected]>");
> MODULE_DESCRIPTION("Freescale ASoC utility code");
> MODULE_LICENSE("GPL v2");
> diff --git a/sound/soc/fsl/fsl_utils.h b/sound/soc/fsl/fsl_utils.h
> index 21b25a11ecda..0cf9d1e7fb14 100644
> --- a/sound/soc/fsl/fsl_utils.h
> +++ b/sound/soc/fsl/fsl_utils.h
> @@ -31,4 +31,34 @@ void fsl_asoc_constrain_rates(struct
> snd_pcm_hw_constraint_list *target_constr,
> const struct snd_pcm_hw_constraint_list
> *original_constr,
> struct clk *pll8k_clk, struct clk *pll11k_clk,
> struct clk *ext_clk, int *target_rates);
> +
> +/* Similar to SOC_SINGLE_XR_SX, but it is for read only registers. */
> +#define FSL_ASOC_SINGLE_XR_SX_EXT_RO(xname, xregbase, xregcount, xnbits, \
> + xmin, xmax, xinvert, xhandler_get) \
> +{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = (xname), \
> + .access = SNDRV_CTL_ELEM_ACCESS_READ | \
> + SNDRV_CTL_ELEM_ACCESS_VOLATILE, \
> + .info = snd_soc_info_xr_sx, .get = xhandler_get, \
> + .private_value = (unsigned long)&(struct soc_mreg_control) \
> + {.regbase = xregbase, .regcount = xregcount, .nbits = xnbits, \
> + .invert = xinvert, .min = xmin, .max = xmax} }
> +
> +int fsl_asoc_get_xr_sx(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol);
> +
> +int fsl_asoc_put_xr_sx(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol);
> +
> +int fsl_asoc_get_enum_double(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol);
> +
> +int fsl_asoc_put_enum_double(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol);
> +
> +int fsl_asoc_get_volsw(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol);
> +
> +int fsl_asoc_put_volsw(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol);
> +
> #endif /* _FSL_UTILS_H */
> --
> 2.34.1
>
signature.asc
Description: PGP signature
