On Sat, Apr 18, 2026 at 02:42:50PM +0530, Sourabh Jain wrote:
> Commit 554b66233623 ("of/fdt: Scan the root node properties earlier")
> moved the invocation of early_init_dt_scan_root() into
> early_init_dt_verify().
>
> early_init_devtree() already calls early_init_dt_verify(), so the root
> node properties are parsed before reaching the explicit call in this
> function.
>
> Keeping the call here results in scanning the root node twice. Remove
> the redundant call and rely on the invocation from
> early_init_dt_verify().
>
> This change keeps the behavior the same and removes an unnecessary
> duplicate call.
>
> Cc: Aditya Gupta <[email protected]>
> Cc: "Christophe Leroy (CS GROUP)" <[email protected]>
> Cc: Hari Bathini <[email protected]>
> Cc: Madhavan Srinivasan <[email protected]>
> Cc: Mahesh Salgaonkar <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: Nicholas Piggin <[email protected]>
> Cc: "Ritesh Harjani (IBM)" <[email protected]>
> Cc: Shivang Upadhyay <[email protected]>
> Cc: Venkat Rao Bagalkote <[email protected]>
> Cc: [email protected]
> Signed-off-by: Sourabh Jain <[email protected]>
> ---
> arch/powerpc/kernel/prom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
> index 9ed9dde7d231..d218c8cc1f73 100644
> --- a/arch/powerpc/kernel/prom.c
> +++ b/arch/powerpc/kernel/prom.c
> @@ -824,7 +824,6 @@ void __init early_init_devtree(void *params)
> fadump_append_bootargs();
>
> /* Scan memory nodes and rebuild MEMBLOCKs */
> - early_init_dt_scan_root();
> early_init_dt_scan_memory_ppc();
>
> /*
> --
> 2.52.0
>
Hi Sourabh,
Patch Looks good to me. Ran a quick boot test also.
Feel free to add.
Tested-by: Shivang Upadhyay <[email protected]>
~Shivang.
