Hi Ritesh, thanks for looking into this patch. My responses to your review comments inline below.
Ritesh Harjani (IBM) <[email protected]> writes: > Amit Machhiwal <[email protected]> writes: > >> So, we would still want to prioritize the whole series >> instead of just this one patch. >> > > Patch-1 could go as a bug fix even in 7.1-rc6 (or maybe with 7.2 > bug fixes). - Maddy? > > So, you may want to add a fixes tag and maybe even cc stable if you are > seeing this issue from older kernels maybe when nestedv2 got introduced? This isnt a 'bug fix' per-se but rather strengthening of compat mode checks so that any non compatible PVR being used by the VMM can be caught early. The hypervisor anyway ultimately prevents non-compatible PVRs from being used by the VMM. So there isnt a bug thats being fixed in this patch. The rest of the patch series builds on top of this patch to advertise the available compatible PVRs to the VMM so that it can further preemptively prevent users from forcibly using a non-compatible PVR. Hence IMHO, this patch can be marked for stable tree and potential candidate for 7.2 merge window. But dont see applicability of a 'fixes' tag to this patch > However the new UAPI discussion might still require more discussion with > the community and I don't think it is ready for 7.2 yet ;) Somewhat agree with the above > > -ritesh > -- Cheers ~ Vaibhav
