Re: [patch 07/18] s390/syscall: Use enter_from_user_mode_randomize_stack()

[Jinjie Ruan]

On 7/8/2026 3:06 AM, Thomas Gleixner wrote:
> enter_from_user_mode_randomize_stack() replaces enter_from_user_mode() and
> the subsequent invocation of add_random_kstack_offset_irqsoff().
> 
> As a bonus this avoids the overhead of get/put_cpu_var() in
> add_random_kstack_offset().
> 
> No functional change.
> 
> Signed-off-by: Thomas Gleixner <t...@kernel.org>
> Cc: Sven Schnelle <sv...@linux.ibm.com>
> Cc: linux-s...@vger.kernel.org
> ---
>  arch/s390/kernel/syscall.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/arch/s390/kernel/syscall.c
> +++ b/arch/s390/kernel/syscall.c
> @@ -97,8 +97,8 @@ void noinstr __do_syscall(struct pt_regs
>  {
>       unsigned long nr;
>  
> -     enter_from_user_mode(regs);
> -     add_random_kstack_offset();
> +     enter_from_user_mode_randomize_stack(regs);

Reviewed-by: Jinjie Ruan <ruanjin...@huawei.com>

> +
>       regs->psw = get_lowcore()->svc_old_psw;
>       regs->int_code = get_lowcore()->svc_int_code;
>       update_timer_sys();
>