When compiling with W=1 on 32-bit PowerPC, -Wunused-but-set-variable was
set, and alongside -Werror caused the build to fail with this error:
```
../arch/powerpc/lib/sstep.c: In function 'analyse_instr':
../arch/powerpc/lib/sstep.c:1350:28: error: variable 'suffix' set but not used
[-Werror=unused-but-set-variable]
1350 | unsigned int word, suffix;
| ^~~~~~
../arch/powerpc/lib/sstep.c:1346:38: error: variable 'rc' set but not used
[-Werror=unused-but-set-variable]
1346 | unsigned int opcode, ra, rb, rc, rd, spr, u;
| ^~
cc1: all warnings being treated as errors
```
Signed-off-by: Link Mauve <[email protected]>
---
arch/powerpc/lib/sstep.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c
index fd57b748cd2b..d49b2ef5d763 100644
--- a/arch/powerpc/lib/sstep.c
+++ b/arch/powerpc/lib/sstep.c
@@ -1342,16 +1342,19 @@ int analyse_instr(struct instruction_op *op, const
struct pt_regs *regs,
{
#ifdef CONFIG_PPC64
unsigned int suffixopcode, prefixtype, prefix_r;
+ unsigned int rc, suffix;
#endif
- unsigned int opcode, ra, rb, rc, rd, spr, u;
+ unsigned int opcode, ra, rb, rd, spr, u;
unsigned long int imm;
unsigned long int val, val2;
unsigned int mb, me, sh;
- unsigned int word, suffix;
+ unsigned int word;
long ival;
word = ppc_inst_val(instr);
+#ifdef CONFIG_PPC64
suffix = ppc_inst_suffix(instr);
+#endif
op->type = COMPUTE;
@@ -1469,7 +1472,9 @@ int analyse_instr(struct instruction_op *op, const struct
pt_regs *regs,
rd = (word >> 21) & 0x1f;
ra = (word >> 16) & 0x1f;
rb = (word >> 11) & 0x1f;
+#ifdef CONFIG_PPC64
rc = (word >> 6) & 0x1f;
+#endif
switch (opcode) {
#ifdef CONFIG_PPC64
--
2.55.0
