On Thu, 30 Jul 2026 13:15:25 +0200, Krzysztof Kozlowski <[email protected]> said: > On 30/07/2026 10:14, Christophe Leroy (CS GROUP) wrote: >> >> On Wed, 29 Jul 2026 16:10:36 +0200, Christophe Leroy (CS GROUP) wrote: >>> Before commit 156460811def ("soc: fsl: qe: Change GPIO driver to a >>> proper platform driver") qe_add_gpiochips() was walking the device >>> tree to find all nodes with compatible "fsl,mpc8323-qe-pario-bank". >>> >>> After that commit the discovery is handled by the platform core, >>> therefore it is necessary to call of_platform_default_populate() on >>> the par_io node. >>> >>> [...] >> >> Applied, thanks! >> >> [1/1] soc: fsl: qe: properly scan GPIO nodes at startup >> commit: cf91e5909e620b77164b53c9b316a5c1f11f9ea7 > > You left very little time to respond to this - one day - and introduced > undocumented disallowed ABI. Please drop the patch. I will be objecting > to the entire pull request. >
Hi, Krzysztof explained to me what to watch out for in such patches. In this case it's about an undocumented node name which now becomes ABI. I'm of course retracting my R-b. Thanks, Bartosz
