On 9/18/26 1:41 PM, Christophe Leroy (CS GROUP) wrote:
Hi Shrikanth,
Le 18/09/2026 à 09:11, Shrikanth Hegde a écrit :
On 9/18/26 8:38 AM, Ethan Nelson-Moore wrote:
The last use of arch/powerpc/kernel/audit_32.h was removed in
commit f26ad12356a2 ("powerpc/audit: Convert powerpc to
AUDIT_ARCH_COMPAT_GENERIC"), but it was left behind. Remove it.
Does it need fixes tag, So that it can propagate correctly?
My understanding is that this patch is not a real bug fix so it doesn't qualify
for -stable trees at the first place. Therefore it shouldn't contain a Fixes:
tag.
See https://docs.kernel.org/process/stable-kernel-rules.html :
Rules on what kind of patches are accepted, and which ones are not, into the
“-stable” tree:
It or an equivalent fix must already exist in Linux mainline (upstream).
It must be obviously correct and tested.
It cannot be bigger than 100 lines, with context.
It must follow the Documentation/process/submitting-patches.rst rules.
It must either fix a real bug that bothers people or just add a device ID.
To elaborate on the former:
It fixes a problem like an oops, a hang, data corruption, a real
security issue, a hardware quirk, a build error (but not for things marked
CONFIG_BROKEN), or some “oh, that’s not good” issue.
Serious issues as reported by a user of a distribution kernel may also
be considered if they fix a notable performance or interactivity issue. As
these fixes are not as obvious and have a higher risk of a subtle regression
they should only be submitted by a distribution kernel maintainer and include
an addendum linking to a bugzilla entry if it exists and additional information
on the user-visible impact.
No “This could be a problem...” type of things like a “theoretical
race condition”, unless an explanation of how the bug can be exploited is also
provided.
No “trivial” fixes without benefit for users (spelling changes,
whitespace cleanups, etc).
Alright. Makes sense.
Reviewed-by: Shrikanth Hegde <[email protected]>
Signed-off-by: Ethan Nelson-Moore <[email protected]>
---
arch/powerpc/kernel/audit_32.h | 7 -------
1 file changed, 7 deletions(-)
delete mode 100644 arch/powerpc/kernel/audit_32.h
diff --git a/arch/powerpc/kernel/audit_32.h b/arch/powerpc/kernel/ audit_32.h
deleted file mode 100644
index c6c79c3041ab..000000000000
--- a/arch/powerpc/kernel/audit_32.h
+++ /dev/null
@@ -1,7 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-#ifndef __AUDIT_32_H__
-#define __AUDIT_32_H__
-
-extern int ppc32_classify_syscall(unsigned);
-
-#endif
