[PATCH 07/12] pseries/plpks: clear SED key data after use

[Srish Srinivasan]

Explicitly clear the temporary buffer containing SED key data after read
and write operations.

Fixes: ec8cf230cecc ("powerpc/pseries: PLPKS SED Opal keystore support")
Cc: sta...@vger.kernel.org # 6.7
Signed-off-by: Srish Srinivasan <ssr...@linux.ibm.com>
Reviewed-by: Greg Joyce <gjo...@linux.ibm.com>
Tested-by: R Nageswara Sastry <rnsas...@linux.ibm.com>
---
 arch/powerpc/platforms/pseries/plpks_sed_ops.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/plpks_sed_ops.c 
b/arch/powerpc/platforms/pseries/plpks_sed_ops.c
index 7c873c9589ef..ac3ec2ca7fbe 100644
--- a/arch/powerpc/platforms/pseries/plpks_sed_ops.c
+++ b/arch/powerpc/platforms/pseries/plpks_sed_ops.c
@@ -84,14 +84,16 @@ int sed_read_key(char *keyname, char *key, u_int *keylen)
 
        ret = plpks_read_os_var(&var);
        if (ret != 0)
-               return ret;
+               goto out;
 
        len = min_t(u16, be32_to_cpu(data.key_len), var.datalen);
        memcpy(key, data.key, len);
        key[len] = '\0';
        *keylen = len;
 
-       return 0;
+out:
+       memzero_explicit(&data, sizeof(data));
+       return ret;
 }
 
 /*
@@ -102,6 +104,7 @@ int sed_write_key(char *keyname, char *key, u_int keylen)
        struct plpks_var var;
        struct plpks_sed_object_data data;
        struct plpks_var_name vname;
+       int ret;
 
        plpks_init_var(&var, keyname);
 
@@ -127,5 +130,8 @@ int sed_write_key(char *keyname, char *key, u_int keylen)
        vname.name = var.name;
        plpks_remove_var(var.component, var.os, vname);
 
-       return plpks_write_var(var);
+       ret = plpks_write_var(var);
+       memzero_explicit(&data, sizeof(data));
+
+       return ret;
 }
-- 
2.52.0