Re: [PATCH v4 01/12] mm/khugepaged: deposit a newly allocated page table on collapse

[Andrew Morton]

On Wed, 23 Sep 2026 08:14:01 +0100 "Lorenzo Stoakes (ARM)" <l...@kernel.org> 
wrote:

> Andrew - would it be possible to make one quick fix up below?
> 
> Fixup is here:
> 
> -             if (!pgtable)
> -                     goto out_nolock;
> +             if (!pgtable) {
> +                     result = SCAN_ALLOC_HUGE_PAGE_FAIL;
> +                     goto out_nolock;
> +             }

--- 
a/mm/khugepaged.c~mm-khugepaged-deposit-a-newly-allocated-page-table-on-collapse-fix
+++ a/mm/khugepaged.c
@@ -1329,8 +1329,10 @@ static enum scan_result collapse_huge_pa
 
        if (is_pmd_order(order)) {
                pgtable = alloc_deposit_pte(mm);
-               if (!pgtable)
+               if (!pgtable) {
+                       result = SCAN_ALLOC_HUGE_PAGE_FAIL;
                        goto out_nolock;
+               }
        }
 
        mmap_read_lock(mm);
_