On Sat, Sep 26, 2026 at 10:10:11PM +0800, Slavin Liu wrote: > Hi Dan, > > On Sat, Sep 26, 2026 at 04:19:38PM +0300, Dan Carpenter wrote: > > The ->get_dma_channel() function pointer returns error pointers not > > NULL. > > > > sound/soc/fsl/fsl_asrc_dma.c:254 fsl_asrc_dma_hw_params() > > warn: 'tmp_chan' is an error pointer or valid > > > > sound/soc/fsl/fsl_easrc.c | (struct fsl_asrc)->get_dma_channel | > > fsl_easrc_get_dma_channel | 1 > > sound/soc/fsl/fsl_asrc.c | (struct fsl_asrc)->get_dma_channel | > > fsl_asrc_get_dma_channel | 1 > > Is this a false positive?: both implementations return > dma_request_slave_channel().
Ah, you're looking at old code. It changed from NULL to error pointers last week. The dma_request_slave_channel() function was deleted entirely since there are no more callers in the kernel. https://lore.kernel.org/all/[email protected]/ regards, dan carpenter
