Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The commit message for "ibmveth: return the error when
set_channels cannot add TX queues" says the bug was "Found by AI-…
--
ibmveth: return the error when set_channels cannot add TX queues
If ibmveth_set_channels() fails to allocate a TX long term buffer for a
new queue, it falls back to the old queue count. The successful
netif_set_real_num_tx_queues() call then overwrote rc, so ethtool -L
reported success. This patch saves the allocation error in alloc_rc and
returns it when the fallback succeeds.
> Found by AI-assisted review of the ibmveth multi-queue RX series and
> confirmed by code inspection. Tested on a POWER10 LPAR with the TX
> buffer allocation forced to fail by a test-only module parameter (not
> part of this patch): ethtool -L tx 8 now fails with -ENOMEM and the
> device keeps its four queues and passes traffic. No kernel selftests
> cover ibmveth.
>
> Fixes: 10c2aba89cc0 ("ibmveth: Ethtool set queue support")
> Signed-off-by: Mingming Cao <[email protected]>
[Severity: Low]
This isn't a bug, but should the trailer block carry an Assisted-by tag?
The message body says the bug was found by AI-assisted review. The
trailers only have Fixes: and Signed-off-by:.
Documentation/process/submitting-patches.rst, in "Using Assisted-by:",
says:
If you used any sort of advanced coding tool in the creation of your
patch, you need to acknowledge that use by adding an Assisted-by tag.
Failure to do so may impede the acceptance of your work.
Documentation/process/coding-assistants.rst gives the format:
Assisted-by: LLM [TOOL1] [TOOL2]
Step 6 of its "Procedure for finding and fixing bugs" section also says
a fix for an AI-found bug should add an Assisted-by tag.
Could an Assisted-by: trailer be added to this commit?
--
Sashiko AI review ·
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261012050518.88858-1-mmc%40linux.ibm.com
