On Dec 29, 2008, at 10:40 AM, Anton Vorontsov wrote:

diff --git a/arch/powerpc/boot/dts/mpc8315erdb.dts b/arch/powerpc/ boot/dts/mpc8315erdb.dts
index d3d3097..5997325 100644
--- a/arch/powerpc/boot/dts/mpc8315erdb.dts
+++ b/arch/powerpc/boot/dts/mpc8315erdb.dts
@@ -22,6 +22,8 @@
                serial0 = &serial0;
                serial1 = &serial1;
                pci0 = &pci0;
+               pci1 = &pci1;
+               pci2 = &pci2;
        };

        cpus {
@@ -330,4 +332,44 @@
                compatible = "fsl,mpc8349-pci";
                device_type = "pci";
        };
+
+       pci1: p...@e0009000 {
+               #address-cells = <3>;
+               #size-cells = <2>;
+               #interrupt-cells = <1>;
+               device_type = "pcie";

should just be pci, not pcie


+               compatible = "fsl,mpc8315-pcie", "fsl,mpc8314-pcie";
+               reg = <0xe0009000 0x00001000 0xb0000000 0x01000000>;

the size on the 0xb0000000 seems wrong


+               ranges = <0x02000000 0 0xa0000000 0xa0000000 0 0x10000000
+                         0x01000000 0 0x00000000 0xb1000000 0 0x00800000>;
+               bus-range = <0 0>;

normally we have this as <0 255> and assume FW updates it.


+               interrupt-map-mask = <0xf800 0 0 7>;
+               interrupt-map = <0 0 0 1 &ipic 1 8
+                                0 0 0 2 &ipic 1 8
+                                0 0 0 3 &ipic 1 8
+                                0 0 0 4 &ipic 1 8>;
+               clock-frequency = <0>;
+               /* cleared by u-boot */
+               status = "not configured";

for pcie nodes we also include the virtual p2p bridge look at the 85xx or 86xx .dts w/pcie in them.

(I'm only commenting on this one, assuming the comments replicate to all other nodes)

- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to