On Thu, Jan 08, 2009 at 03:27:10PM +0800, Liu Dave wrote: > > +static void __iomem *mpc83xx_pcie_remap_cfg(struct pci_bus *bus, > > + unsigned int devfn, > > [snip] > > > + if (pcie->dev_base == dev_base) > > + goto mapped; > > + > > + out_le32(hose->cfg_data + PEX_OUTWIN0_TAL, dev_base); > > + > > + pcie->dev_base = dev_base; > > Do we need local_irq_save/local_irq_restore between them?
No, I don't think we need it. drivers/pci/access.c hold an irqsave spinlock for ->read and ->write callbacks. > out_le32(PEX_OUTWIN0_TAL,...) and pcie->dev_base = dev_base; > > +mapped: > > + return pcie->cfg_map + offset; > > +} Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
