David Miller <da...@davemloft.net> wrote on 24/03/2009 22:22:09: > > From: Joakim Tjernlund <joakim.tjernl...@transmode.se> > Date: Tue, 24 Mar 2009 11:37:11 +0100 > > > David Miller <da...@davemloft.net> wrote on 23/03/2009 19:49:28: > > > > > > From: Joakim Tjernlund <joakim.tjernl...@transmode.se> > > > Date: Mon, 23 Mar 2009 11:17:39 +0100 > > > > > > > Sorry for the WS damaged patch, but my current company mailer cannot > > > > handle inline patches. Due to this we are setting up a new mail system > > > > but it will be a few days before this is ready. > > > > Therefore I am attaching this patch as well, use that one > > > > to apply instaed of the inline variant. > > > > > > This patch has other problems, anyways. > > > > > > > +#if 0 > > > > +/* not yet */ > > > > + .ndo_set_mac_address = ucc_geth_set_mac_address, > > > > + .ndo_change_mtu = ucc_geth_change_mtu, > > > > + .ndo_do_ioctl = ucc_geth_do_ioctl, > > > > +#endif > > > > > > Don't do stuff like this, please. Even the code you are > > > copying from doesn't have the set_mac_address method > > > assignment proceted by #if 0 stuff. > > > > > > Just get rid of all the unused stuff completely. > > > > OK, here is a new version. The #if 0 ..#endif has been removed. > > Missing ".ndo_set_mac_address = eth_set_mac_address," and > also ".ndo_change_mtu = eth_change_mtu".
I don't follow. Are these mandatory now? They were not in the old impl. either. > > Also please inline your patches so that people can quote them in > replies. I know, but my mail system is screwing up WS ATM so I can't. Working on it though. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev