On Wed, Apr 01, 2009 at 04:30:29PM +0400, Anton Vorontsov wrote: > On Wed, Apr 01, 2009 at 10:09:55PM +1100, David Gibson wrote: > > On Wed, Apr 01, 2009 at 09:31:34AM +0200, Wolfgang Grandegger wrote: > > > Hi David, > > > > > > this patch went out by mistake, sorry. > > > > > > David Gibson wrote: > > > > On Tue, Mar 31, 2009 at 02:37:33PM +0200, Wolfgang Grandegger wrote: > > > >> Index: linux-2.6/arch/powerpc/boot/dts/socrates.dts > > > >> =================================================================== > > > >> --- linux-2.6.orig/arch/powerpc/boot/dts/socrates.dts 2009-03-31 > > > >> 13:24:38.078719288 +0200 > > > >> +++ linux-2.6/arch/powerpc/boot/dts/socrates.dts 2009-03-31 > > > >> 13:47:56.986720719 +0200 > > > >> @@ -52,6 +52,7 @@ > > > >> soc8...@e0000000 { > > > >> #address-cells = <1>; > > > >> #size-cells = <1>; > > > >> + device_type = "soc"; > > > > > > > > You should not be adding device_type to a new board's dts. You > > > > *especially* shouldn't be doing that with no patch comment explaining > > > > why. > > > > > > In the final patch I have removed the device_type = "soc", but it makes > > > trouble as some mpc85xx rely on it. > > > > Um.. what? Some mpc85xx? This is the dts for *one specific board*, I > > don't see how something that affects "some mpc85xx" is relevant. > > Not some, but *all* mpc85xx. The thing is that U-Boot is searching > for device_type = "soc" to fixup some properties (for example, > bus-frequency) for all mpc85xx parts, so you can't easily remove > the device_type w/o breaking boot for firmwares that customers have > pre-programmed in their products.
I thought that was fixed in current u-boot versions. > Note that upgrading firmware without JTAG is dangerous, so it's not > an option to "force" everybody to upgrade their firmware just > because we want to remove some cruft from the device tree. I realise that, but again this is a *new board*, which presumably can use an up-to-date u-boot version. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev