Ben Dooks wrote:
On Wed, Apr 29, 2009 at 08:43:14AM -0500, Kumar Gala wrote:
On Apr 22, 2009, at 4:56 PM, Ben Dooks wrote:
On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala wrote:
On Apr 21, 2009, at 7:49 AM, Mark Ware wrote:
Recent DMA changes result in a BUG() when NULL is passed to
dma_alloc_coherent in place of a device.
Signed-off-by: Mark Ware <mw...@elphinstone.net>
---
This patch fixes the BUG() during boot that has appeared during the
2.6.30 window. It has been tested and appears correct on my 8280
based
board.
Sent to both linuxppc-dev and linux-i2c, since I'm not sure where it
belongs.
drivers/i2c/busses/i2c-cpm.c | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
Acked-by: Kumar Gala <ga...@kernel.crashing.org>
Ben, I'm expecting you to pick this up unless you tell me otherwise.
Yes.
This go in yet?
I've had to do a manual apply due to some changes in the
driver, so can someone please do a build of my git tree
at:
git://aeryn.fluff.org.uk/bjdooks/linux.git i2c-for-2630-rc5
or tell me which arch and defconfig to build.
Fails to build, due to a typo. Once fixed (diff below), it builds
and tests OK on my MPC8280 based hardware
Thanks.
Mark
diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
index b4c0448..b5db8b8 100644
--- a/drivers/i2c/busses/i2c-cpm.c
+++ b/drivers/i2c/busses/i2c-cpm.c
@@ -585,7 +585,7 @@ static int __devinit cpm_i2c_setup(struct cpm_i2c *cpm)
out_muram:
for (i = 0; i < CPM_MAXBD; i++) {
if (cpm->rxbuf[i])
- dma_free_coherent(&cpm->ofdev->devL, CPM_MAX_READ + 1,
+ dma_free_coherent(&cpm->ofdev->dev, CPM_MAX_READ + 1,
cpm->rxbuf[i], cpm->rxdma[i]);
if (cpm->txbuf[i])
dma_free_coherent(&cpm->ofdev->dev, CPM_MAX_READ + 1,
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
