Dear Grant, in message <fa686aa40905061333q29c263c8p24856c048e30f...@mail.gmail.com> you wrote: > ... > > #ifdef CONFIG_FS_ENET_HAS_FEC > > +#ifdef CONFIG_FS_ENET_MPC5121_FEC > > + { > > + .compatible = "fsl,mpc5121-fec", > > + .data = (void *)&fs_fec_ops, > > + }, > > +#else > > { > > .compatible = "fsl,pq1-fec-enet", > > .data = (void *)&fs_fec_ops, > > }, > > #endif > > +#endif > > Hmmm. A lot of these #ifdefs in here. Does this have a multiplatform > impact? Not to mention the fact that it's just plain ugly. :-)
Agreed that it's ugly, but duplicatio9ng the code would have been even worse. I don't think that it has multiplatform - at least not as long as you don't ask for one image that runs on 83xx and on 512x. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Our business is run on trust. We trust you will pay in advance. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev