On Wed, 2009-06-10 at 18:24 -0500, Kumar Gala wrote:
> > + form-factor = "6U cPCI";
> > + boot-bank = <0x0>; /* 0: Primary flash, 1: Secondary flash */
>
> I'm not a fan of taking device trees with properties that are
> specified anywhere.
I can just delete them for now. They're purely informational at this
point, but might be used in the future.
> > + soc8...@ef000000 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + device_type = "soc";
> > + compatible = "simple-bus";
>
> should have a compat like:
>
> compatible = "fsl,mpc8572-immr", "simple-bus";
Are you sure about this? I only see "simple-bus" in the mpc8572ds.dts
files in mainline and your next branch -- so I was just following your
lead here.
I'll split up the patch as well. It's not obvious where the 4-line boot
wrapper change should go, so I can make that one separate as well unless
you object.
--
Nate Case <nc...@xes-inc.com>
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
