Hi Sean, On Mon, Jun 22, 2009 at 1:36 AM, Sean MacLennan<smaclen...@pikatech.com> wrote: > On Mon, 22 Jun 2009 08:25:04 +1000 > Benjamin Herrenschmidt <b...@kernel.crashing.org> wrote: > >> Right, our interrupt controllers need those fixes, they are low >> on my priority list since it's a reasonably harmless warning and I'm >> still chasing some actual breakage (though maybe not directly related >> to your patches). >> >> Kumar already submitted a couple, Frans, feel free to beat me >> at converting UIC (just use kmalloc directly in there instead >> of alloc_bootmem). > > I can make the changes to UIC if you want. They badness is harmless (it > ends up calling kzalloc anyway), but hard to explain to our PV (Product > Verification) department that they can ignore what looks like a crash ;)
Right. We can also wrap the WARN_ON() in CONFIG_DEBUG_BOOTMEM or something too but I'd prefer a proper fix here. Pekka _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev