On Wed, Oct 7, 2009 at 3:49 AM, Wolfram Sang <w.s...@pengutronix.de> wrote: > On Wed, Oct 07, 2009 at 08:40:37AM +0200, Heiko Schocher wrote: >> - serial Console on PSC1 >> - 64MB SDRAM >> - MTD CFI Flash >> - Ethernet FEC >> - IDE support >> >> Signed-off-by: Heiko Schocher <h...@denx.de> > > Sorry for finding things incrementally, but I think there is still one issue > left. Once this is sorted out, you could add my: > > Reviewed-by: Wolfram Sang <w.s...@pengutronix.de> > [...] >> + soc5...@f0000000 { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + compatible = "fsl,mpc5200-immr", >> + "fsl,mpc5200b-immr"; > > You should decide on the latter one only here.
Besides, the order is wrong. The exact version (mpc5200b) always appears before the list of backward compatible values (the non-'b' version). But Wolfram is right. The IMMR node of the mpc5200b is *not* wholly backwards compatible with fsl,mpc5200-immr, so 'fsl,mpc5200-immr' should not be in the list. fsl,mpc5200-<blah> only appears in the child nodes when the specific device truly is backwards compatible. Compare your .dts file line-for-line with one of the in-tree mpc5200b .dts files. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev