From: Anton Vorontsov <avoront...@ru.mvista.com> Date: Mon, 12 Oct 2009 20:00:00 +0400
> Here are few patches that add support for hibernation for gianfar > driver. > > Technically, we could just do gfar_close() and then gfar_enet_open() > sequence to restore gianfar functionality after hibernation, but > close/open does so many unneeded things (e.g. BDs buffers freeing and > allocation, IRQ freeing and requesting), that I felt it would be much > better to cleanup and refactor some code to make the hibernation [and > not only hibernation] code a little bit prettier. I applied all of this, it's a really nice patch set. If there are any problems we can deal with it using follow-on fixups. I noticed something, in patch #3 where you remove the spurious wrap bit setting in startup_gfar(). It looks like that was not only spurious but it was doing it wrong too. It's writing garbage into the status word, because it's not using the BD_LFLAG() macro to shift the value up 16 bits. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
