Segher Boessenkool wrote:
>> +static struct of_device_id gamecube_of_bus[] = {
>> +    { .compatible = "nintendo,flipper", },
>> +    { },
>> +};
>> +
>> +static int __init gamecube_device_probe(void)
>> +{
>> +    if (!machine_is(gamecube))
>> +        return 0;
>> +
>> +    of_platform_bus_probe(NULL, gamecube_of_bus, NULL);
>> +    return 0;
>> +}
> 
> You really do not need a platform bus as far as I can see?
> 

We need it as it currently doesn't match with the default bus ids.

const struct of_device_id of_default_bus_ids[] = {
        { .type = "soc", },
        { .compatible = "soc", },
        { .type = "plb5", },
        { .type = "plb4", },
        { .type = "opb", },
        { .type = "simple", },
        {},
};

Should I introduce a .type property matching any of those above in the soc 
node, and get rid of the explicit bus probe?

Thanks,
Albert
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to