On 12/01/2009 07:36 PM, Benjamin Herrenschmidt wrote:
This is a libata driver for the "macio" IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features of its predecessor, including mediabay hotplug
and suspend/resume. It should also support module load/unload.
The timing calculations have been simplified to use pre-calculated tables
compared to drivers/ide/pmac.c and it uses the new mediabay interface
provided by a previous patch.
Signed-off-by: Benjamin Herrenschmidt<b...@kernel.crashing.org>
---
v2. Better tested now, seems to be reasonably solid.
Addressed Tejun comments and made remove more robust vs. media-bay,
should also fix Andreas problem.
drivers/ata/Kconfig | 10
drivers/ata/Makefile | 1
drivers/ata/pata_macio.c | 1427
+++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 1438 insertions(+)
Looks fine to me. Two minor comments, which might perhaps be ignored if
that is your taste:
* prefer enums to #define's, for constants
* prefer direct function call to "ap->ops->foo_bar()", because
ap->ops->foo_bar() is guaranteed to be a constant value known to the
driver. The driver is the entity responsible for the function pointer.
Maybe saves a cycle or two. Not terribly important, but hey, calling
ap->ops->sff_exec_command() from pata_macio_bmdma_setup() is a hot path.
Jeff
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
