Hi Olof, On Mon, 2009-12-21 at 21:48 -0600, Olof Johansson wrote: > Hi, > > On Mon, Dec 21, 2009 at 07:50:42PM -0600, Peter Tyser wrote: > > diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile > > index bb2465b..e56ec21 100644 > > --- a/arch/powerpc/boot/Makefile > > +++ b/arch/powerpc/boot/Makefile > > @@ -310,6 +310,9 @@ $(obj)/zImage.iseries: vmlinux > > $(obj)/uImage: vmlinux $(wrapperbits) > > $(call if_changed,wrap,uboot) > > > > +$(obj)/uImage.fit.%: vmlinux $(obj)/%.dtb $(wrapperbits) > > + $(call if_changed,wrap,uboot.fit,,$(obj)/$*.dtb) > > + > > $(obj)/cuImage.initrd.%: vmlinux $(obj)/%.dtb $(wrapperbits) > > $(call if_changed,wrap,cuboot-$*,,$(obj)/$*.dtb,$(obj)/ramdisk.image.gz) > > > > @@ -349,7 +352,7 @@ install: $(CONFIGURE) $(addprefix $(obj)/, $(image-y)) > > > > # anything not in $(targets) > > clean-files += $(image-) $(initrd-) cuImage.* dtbImage.* treeImage.* \ > > - zImage zImage.initrd zImage.chrp zImage.coff zImage.holly \ > > + uImage.* zImage zImage.initrd zImage.chrp zImage.coff zImage.holly \ > > Please no. It's not entirely uncommon that I will save a "known good" > binary in the build tree for a while, by copying it aside with a different > suffix. That'd give me one very big surprise in this case.
You're right that it'd probably be better if the clean pattern was uImage.fit.* to be more restrictive, but your concern would still exist, as it does for a number of other image formats already (cuImage.*, simpleImage.*, etc). I can't think of a way to work around that issue though... Any ideas? Don't keep backup images in arch/powerpc/boot?:) Thanks for the feedback, Peter _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
