Hi Roman. I'm finally getting some time to look at these with a bit more detail.
On Mon, Dec 21, 2009 at 11:57 PM, Roman Fietze <roman.fie...@telemotive.de> wrote: > > Signed-off-by: Roman Fietze <roman.fie...@telemotive.de> > --- > arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c > b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c > index 929d017..4c84aa5 100644 > --- a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c > +++ b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c > @@ -165,7 +165,7 @@ static void mpc52xx_lpbfifo_kick(struct > mpc52xx_lpbfifo_request *req) > > bit_fields = req->cs << 24 | 0x000008; > if (!write) > - bit_fields |= 0x010000; /* read mode */ > + bit_fields |= 0x010000; /* read mode */ > out_be32(lpbfifo.regs + LPBFIFO_REG_CONTROL, bit_fields); > > /* Kick it off */ > @@ -279,7 +279,7 @@ static irqreturn_t mpc52xx_lpbfifo_irq(int irq, void > *dev_id) > else > do_callback = 1; > > - out: > +out: The label 1 space indentation is intentional so coax diff into choosing the right line for the function name. There are plenty of examples of this in the kernel. The rest of the changes are valid, but unimportant. It's not worth the effort. In most cases I don't bother fixing whitespace unless they style violations are so gratuitous that it is hard to read the code otherwise, or if I'm already touching the offending line. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
