Grant Likely wrote:
Please don't. I know that a lot of other 5200 code uses register map structures in this way, but I consider it bad practice. I coded this driver without a structure for a reason. The reason I haven't removed the other 5200 register map structures is the code impact would be huge, it would probably cause breakage, and it would break all out-of-tree patches touching the same code for no measurable advantage.
FWIW, over on the U-Boot side patches are getting NACKed by Wolfgang if they don't use register structures. :-P
They're nice from a type-safety and namespacing perspective, though they get ugly pretty quickly if there are gaps.
-Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
