On Tue, Jan 19, 2010 at 09:24:08PM +0100, Anatolij Gustschin wrote: > From: Piotr Ziecik <[email protected]> > > Adds NAND Flash Controller driver for MPC5121 Revision 2. > All device features, except hardware ECC and power management, > are supported. > > Signed-off-by: Piotr Ziecik <[email protected]> > Signed-off-by: Wolfgang Denk <[email protected]> > Signed-off-by: Anatolij Gustschin <[email protected]> > Cc: <[email protected]> > Cc: Grant Likely <[email protected]> > Cc: John Rigby <[email protected]> > ---
Please include a logfile with changes since the last version. This really
helps.
> +static int __init mpc5121_nfc_probe(struct of_device *op,
> + const struct of_device_id *match)
[...]
> +{
> + /* Support external chip-select logic on ADS5121 board */
> + rootnode = of_find_node_by_path("/");
> + if (of_device_is_compatible(rootnode, "fsl,mpc5121ads")) {
> + retval = ads5121_chipselect_init(mtd);
> + if (retval) {
> + dev_err(dev, "Chipselect init error!\n");
> + of_node_put(rootnode);
> + return retval;
> + }
> +
> + chip->select_chip = ads5121_select_chip;
> + }
> + of_node_put(rootnode);
If we have to live with the platform-stuff being in the driver, maybe a table
having the compatible-string and an init-function pointer per entry will make
it scale better with the number of boards?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
_______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
