From: Anatolij Gustschin <[email protected]>
Date: Thu, 21 Jan 2010 03:13:18 +0100
> struct fec_info {
> - fec_t __iomem *fecp;
> + void __iomem *fecp;
...
> /* write */
> -#define FW(_fecp, _reg, _v) __fs_out32(&(_fecp)->fec_ ## _reg, (_v))
> +#define FW(_regp, _reg, _v) __fs_out32((_regp)->fec_ ## _reg, (_v))
...
> +/* register address macros */
> +#define fec_reg_addr(_type, _reg) \
> + (fep->fec.rtbl->fec_##_reg = (u32 __iomem *)((u32)fep->fec.fecp + \
> + (u32)&((__typeof__(_type) *)NULL)->fec_##_reg))
> +
> +#define fec_reg_mpc8xx(_reg) \
> + fec_reg_addr(struct mpc8xx_fec, _reg)
> +
> +#define fec_reg_mpc5121(_reg) \
> + fec_reg_addr(struct mpc5121_fec, _reg)
This is a step backwards in my view.
If you use the "fec_t __iomem *" type for the register
pointer, you simply use &p->fecp->XXX to get the I/O
address of register XXX and that's what you pass to
the appropriate I/O accessor routines.
Now you've made it typeless, and then you have to walk
through all of these contortions to get the offset.
I don't want to apply this, sorry...
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev
