On Mon, 22 Feb 2010 21:21:53 -0800 "Feng Kan" <f...@amcc.com> wrote:
> Hi Sean: > > I will withdraw this patch. I had a talk with the U-Boot guys. The > reason for this patch was to support those guys that had their ECC > ordering at (213) on the older version of the kernel. Upgrading to > (123) may be problematic. Since without a jtag it would be a bit > complex. > I still think this NAND_ECC_SMC define is somewhat missleading. Given > that both 1-2-3 and 2-1-3 are supported by the correction routine. The 213 ordering is my fault. I changed it to match what u-boot did rather than keeping the order from the old arch-ppc driver. Believe me, I have been raked over the coals at work for this :( I agree the NAND_ECC_SMC is misleading. The NAND_ECC_SMC *is* correct. The confusion is that the SMC is handled later on, so you must keep the byte order unaltered in this routine. I wrote a simple driver that allows you to boot with the old kernel, insmod the driver, burn new images (including a kernel with the correct byte order!), and then reboot into the new kernel. If anybody wants this, just ask. It will take a little work to get it working with other NANDs since it needs to know the NAND name to get the mtd structure. It also assumes you have a way to write to NAND in user mode. The mtd-utils flash_eraseall and nandwrite are good enough. Cheers, Sean _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
