On Fri, Jan 21, 2011 at 10:19 AM, Jon Loeliger <j...@jdl.com> wrote: >> >> For this to make sense, it really needs to also rename irq_host_ops >> structure, the IRQ_HOST_MAP* #defines, and the irq_*_host functions. >> It also /should/ adjust the users of irq_domain to rename function >> local variables and structure members. Otherwise there will be an >> even worse mismatch in naming. > > Happy to do so, but last time we talked about this, we decided > not to do *that* aspect of the rename with this patch, and that > we'd get to it later with follow on patches once this step was done.
I always reserve the right to change my mind. }:-> Sorry about that, but I actually applied the patch this morning with the thought that I'd get Linus to pick it up late to avoid collisions in linux-next. However, when I actually looked at the result I realized that at the very least, the irq_host_ops, the #defines, and the irq_*_host functions absolutely have to be renamed at the same time. Not necessarily in the same patch, but definitely at the same time. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev