On Tue, Feb 08, 2011 at 09:20:46AM -0800, Ira W. Snyder wrote:
> > > +static DEVICE_ATTR(enable, S_IWUGO | S_IRUGO, data_en_show,
> > > data_en_set);
> >
> > Are all of these really needed or most of them are for debug?
> >
>
> Most are for debugging. They have proved useful a few times in
> production to track down bugs.
File mode should probably not be world writable.
(checkpatch.pl should warn you about this now btw)
Dave
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev
