On Tue, 2011-06-28 at 09:50 +0800, [email protected] wrote:
> From: Liu Shuo <[email protected]>
>
> The global data fsl_lbc_ctrl_dev->nand don't have to be freed in
> fsl_elbc_chip_remove(). The right place to do that is in
> fsl_elbc_nand_remove()
> if elbc_fcm_ctrl->counter is zero.
>
> Signed-off-by: Liu Shuo <[email protected]>
> ---
> drivers/mtd/nand/fsl_elbc_nand.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/fsl_elbc_nand.c
> b/drivers/mtd/nand/fsl_elbc_nand.c
> index 0bb254c..a212116 100644
> --- a/drivers/mtd/nand/fsl_elbc_nand.c
> +++ b/drivers/mtd/nand/fsl_elbc_nand.c
> @@ -829,7 +829,6 @@ static int fsl_elbc_chip_remove(struct fsl_elbc_mtd *priv)
>
> elbc_fcm_ctrl->chips[priv->bank] = NULL;
> kfree(priv);
> - kfree(elbc_fcm_ctrl);
> return 0;
> }
Do we have to assign fsl_lbc_ctrl_dev->nand to NULL in
fsl_elbc_nand_remove() then? I think that assignment can be killed then.
if (!elbc_fcm_ctrl->counter) {
fsl_lbc_ctrl_dev->nand = NULL;
kfree(elbc_fcm_ctrl);
}
--
Best Regards,
Artem Bityutskiy
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev
