On Wed, Aug 10, 2011 at 09:45:17AM -0500, Kumar Gala wrote: > > On Aug 10, 2011, at 9:15 AM, Robin Holt wrote: > > > On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote: > >> Hi Robin, > >> > >> On 08/10/2011 05:06 AM, Robin Holt wrote: > >>> In working with the socketcan developers, we have come to the conclusion > >>> the Documentation...fsl-flexcan.txt device tree documentation needs to > >>> be cleaned up. The driver does not depend upon any properties other > >> > >> Your first sentence could be misleading. Please just describe what the > >> patch does and why, something like: > >> > >> "This patch cleans up the documentation of the device-tree binding for > >> the Flexcan devices on Freescale's PowerPC and ARM cores. Extra > >> properties are not needed as the frequency of the source clock is > >> fixed..." and so on. > > > > I borrowed heavily from your message. ;) > > > >>> than the required properties so we are removing the file. Additionally, > >>> the p1010*dts* files are not following the standard for node naming in > >>> that they have a trailing -v1.0. > >> > >>> Signed-off-by: Robin Holt <h...@sgi.com> > >>> To: Marc Kleine-Budde <m...@pengutronix.de>, > >>> To: Wolfgang Grandegger <w...@grandegger.com>, > >>> To: U Bhaskar-B22300 <b22...@freescale.com> > >>> To: Scott Wood <scottw...@freescale.com> > >>> Cc: socketcan-c...@lists.berlios.de, > >>> Cc: net...@vger.kernel.org, > >>> Cc: PPC list <linuxppc-dev@lists.ozlabs.org> > >>> Cc: Kumar Gala <ga...@kernel.crashing.org> > >>> --- > >>> .../devicetree/bindings/net/can/fsl-flexcan.txt | 61 > >>> -------------------- > >>> arch/powerpc/boot/dts/p1010rdb.dts | 8 --- > >>> arch/powerpc/boot/dts/p1010si.dtsi | 8 +- > >>> 3 files changed, 4 insertions(+), 73 deletions(-) > >>> delete mode 100644 > >>> Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > > I don't understand how we can do this? What binding spec covers the P1010 > CAN support if you remove this?
We have added it back in based upon an earlier comment from Wolfgang. I will post a new version shortly. Robin _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
