Hi Timur,
On Thu, 17 Nov 2011 12:57:39 -0600 Timur Tabi <ti...@freescale.com> wrote:
>
> @@ -129,44 +144,117 @@ static void p1022ds_set_gamma_table(enum
> fsl_diu_monitor_port port,
> */
> static void p1022ds_set_monitor_port(enum fsl_diu_monitor_port port)
> {
> - struct device_node *np;
> - void __iomem *pixis;
> - u8 __iomem *brdcfg1;
> + struct device_node *guts_node = NULL;There is no point in initialising this as it is assigned before being used. > + struct device_node *indirect_node = NULL; > + struct ccsr_guts_85xx __iomem *guts = NULL; > + u8 __iomem *lbc_lcs0_ba = NULL; > + u8 __iomem *lbc_lcs1_ba = NULL; And if you had multiple error path labels, you could avoid these others as well (and the NULL checks on the error path). -- Cheers, Stephen Rothwell s...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
pgpNr80x3d08h.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
