Zhao Chenhui wrote: > If the guts node is missing, this code snippet will be skipped. If the guts > node is existed, > the return value of of_iomap(), namely guts, will be tested. If it is NULL, > it shows > that there is error in dts, or the ioremap() in of_iomap() failed. I think > these errors are fatal errors, so I print an error info and return.
Ok, I see your point now. I'm concerned about what might happen if someone else updates mpc85xx_smp_init() in the future, but there's nothing actually wrong with your patch today. -- Timur Tabi Linux kernel developer at Freescale _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
