Hi Michael,

On Wed, 12 Sep 2012 17:52:40 +1000 Michael Ellerman <[email protected]> 
wrote:
>
> +#define DUMP(name, format) \
> +     printf(" %-*s = %#-*"format"\t(0x%lx)\n", 16, #name, 18, p->name, \
> +             (u64)((void *)&(p->name) - (void *)p));

I must say that I hate macros that reference (assumed) globals and
shouldn't you use offsetof(struct paca_struct, name) (from
linux/stddef.h)?

-- 
Cheers,
Stephen Rothwell                    [email protected]

Attachment: pgpzwe5KPTrCY.pgp
Description: PGP signature

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to