Each call to the co-processor, with exception of the last call, needs to
send data that is multiple of block size. As consequence, any remaining
data is kept in the internal NX context.

This patch fixes a bug in the driver that causes it to save incorrect
data into the context when data is bigger than the block size.

Reviewed-by: Joy Latten <jmlat...@linux.vnet.ibm.com>
Signed-off-by: Marcelo Cerri <mhce...@linux.vnet.ibm.com>
---
 drivers/crypto/nx/nx-sha256.c | 2 +-
 drivers/crypto/nx/nx-sha512.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/nx/nx-sha256.c b/drivers/crypto/nx/nx-sha256.c
index 6547a71..da0b24a 100644
--- a/drivers/crypto/nx/nx-sha256.c
+++ b/drivers/crypto/nx/nx-sha256.c
@@ -129,7 +129,7 @@ static int nx_sha256_update(struct shash_desc *desc, const 
u8 *data,
                NX_CPB_FDM(csbcpb) |= NX_FDM_CONTINUATION;
 
                total -= to_process;
-               data += to_process;
+               data += to_process - sctx->count;
                sctx->count = 0;
                in_sg = nx_ctx->in_sg;
        } while (leftover >= SHA256_BLOCK_SIZE);
diff --git a/drivers/crypto/nx/nx-sha512.c b/drivers/crypto/nx/nx-sha512.c
index 236e6af..4ae5b0f 100644
--- a/drivers/crypto/nx/nx-sha512.c
+++ b/drivers/crypto/nx/nx-sha512.c
@@ -131,7 +131,7 @@ static int nx_sha512_update(struct shash_desc *desc, const 
u8 *data,
                NX_CPB_FDM(csbcpb) |= NX_FDM_CONTINUATION;
 
                total -= to_process;
-               data += to_process;
+               data += to_process - sctx->count[0];
                sctx->count[0] = 0;
                in_sg = nx_ctx->in_sg;
        } while (leftover >= SHA512_BLOCK_SIZE);
-- 
1.7.12

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to