> Commit e82b89a6f19bae73fb064d1b3dd91fcefbb478f4 used strcat instead of > strcpy which can result in an overflow of newlines on the buffer. ... > --- a/arch/powerpc/kernel/vio.c > +++ b/arch/powerpc/kernel/vio.c > @@ -1531,12 +1531,12 @@ static ssize_t modalias_show(struct device *dev, > struct device_attribute > *attr, > > dn = dev->of_node; > if (!dn) { > - strcat(buf, "\n"); > + strcpy(buf, "\n"); > return strlen(buf); > } > cp = of_get_property(dn, "compatible", NULL); > if (!cp) { > - strcat(buf, "\n"); > + strcpy(buf, "\n"); > return strlen(buf); > }
Why not just: buf[0] = '\n'; buf[1] = 0; return 1; The assignment to buf[1] might not even be needed. David _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev