[snip] > +/* RGMII bridge supports only GMII/TBI and RGMII/RTBI PHYs */ > +static inline int rgmii_valid_mode(int phy_mode) > +{ > + return phy_mode == PHY_MODE_GMII || > + phy_mode == PHY_MODE_MII || > + phy_mode == PHY_MODE_RGMII || > + phy_mode == PHY_MODE_TBI || > + phy_mode == PHY_MODE_RTBI; > +} > + > +static inline const char *rgmii_mode_name(int mode) > +{ > + switch (mode) { > + case PHY_MODE_RGMII: > + return "RGMII"; > + case PHY_MODE_TBI: > + return "TBI"; > + case PHY_MODE_GMII: > + return "GMII"; > + case PHY_MODE_MII: > + return "MII"; > + case PHY_MODE_RTBI: > + return "RTBI"; > + default: > + BUG(); > + }
Any reasons why you are duplicating what is available in drivers/of/of_net.c ::of_get_phy_mode()? -- Florian _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev