Currently some errors/info to be reported use printk and the rest pr_fmt(). This patch makes the complete error/event logging uniform.
Signed-off-by: Deepthi Dharwar <deep...@linux.vnet.ibm.com> --- arch/powerpc/platforms/powernv/opal-elog.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal-elog.c b/arch/powerpc/platforms/powernv/opal-elog.c index 0f67faa..78d3828 100644 --- a/arch/powerpc/platforms/powernv/opal-elog.c +++ b/arch/powerpc/platforms/powernv/opal-elog.c @@ -63,7 +63,7 @@ void opal_elog_ack(uint64_t ack_id) struct opal_err_log *record, *next; bool found = false; - printk(KERN_INFO "OPAL Log ACK=%llx", ack_id); + pr_info("OPAL Log ACK=%llx", ack_id); /* once user acknowledge a log delete record from list */ spin_lock_irqsave(&opal_elog_lock, flags); @@ -189,7 +189,7 @@ static void opal_elog_read(void) /* read log size and log ID from OPAL */ rc = opal_get_elog_size(&log_id, &elog_size, &elog_type); if (rc != OPAL_SUCCESS) { - pr_err("ELOG: Opal log read failed\n"); + pr_err("Opal log read failed\n"); return; } if (elog_size >= OPAL_MAX_ERRLOG_SIZE) @@ -203,7 +203,7 @@ static void opal_elog_read(void) rc = opal_read_elog(__pa(err_log_data), elog_size, log_id); if (rc != OPAL_SUCCESS) { mutex_unlock(&err_log_data_mutex); - pr_err("ELOG: log read failed for log-id=%llx\n", log_id); + pr_err("Reading of log failed for log-id=%llx\n", log_id); /* put back the free node. */ spin_lock_irqsave(&opal_elog_lock, flags); list_add(&record->link, &elog_ack_list); @@ -265,7 +265,7 @@ static int init_err_log_buffer(void) buf_ptr = vmalloc(sizeof(struct opal_err_log) * MAX_NUM_RECORD); if (!buf_ptr) { - printk(KERN_ERR "ELOG: failed to allocate memory.\n"); + pr_err("Failed to allocate memory for error logging buffers.\n"); return -ENOMEM; } memset(buf_ptr, 0, sizeof(struct opal_err_log) * MAX_NUM_RECORD); @@ -359,15 +359,13 @@ int __init opal_elog_init(void) rc = sysfs_create_bin_file(opal_kobj, &opal_elog_attr); if (rc) { - printk(KERN_ERR "ELOG: unable to create sysfs file" - "opal_elog (%d)\n", rc); + pr_err("Unable to create sysfs file opal_elog (%d)\n", rc); return rc; } rc = sysfs_create_file(opal_kobj, &opal_elog_ack_attr.attr); if (rc) { - printk(KERN_ERR "ELOG: unable to create sysfs file" - " opal_elog_ack (%d)\n", rc); + pr_err("Unable to create sysfs file opal_elog_ack (%d)\n", rc); return rc; } _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev