On Wed, 2014-03-13 at 2:46 AM, Scott wrote:
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, March 13, 2014 2:46 AM
> To: Zhao Qiang-B45475
> Cc: [email protected]; Wood Scott-B07421; Xie Xiaobo-R63061
> Subject: Re: [PATCH] T1040RDB: add qe node for T1040RDB dts
>
> On Wed, 2014-03-12 at 16:26 +0800, Zhao Qiang wrote:
> > Signed-off-by: Zhao Qiang <[email protected]>
> > ---
> > arch/powerpc/boot/dts/t1040rdb.dts | 43
> > ++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 43 insertions(+)
>
> Presumably this is on top of this patch:
> http://patchwork.ozlabs.org/patch/314138/
>
> ...since there's no existing t1040 device tree support. Always mention
> when your patch is on top of a patch that hasn't yet been merged and
> isn't in the same patch set.
>
> At least some of this stuff seems like it should be in t1040si-post.dts
> (or a file included by it), rather than the board dts.
Every board can use ucc differently, It is not correct to put this node into
t1040si-post.dtsi.
For example t1040qds can use ucc1 to tdm while maybe t1040rdb use ucc1 to uart.
>
> > + tdma: ucc@2000 {
> > + compatible = "fsl,ucc-tdm";
> > + rx-clock-name = "clk3";
> > + tx-clock-name = "clk4";
> > + fsl,rx-sync-clock = "rsync_pin";
> > + fsl,tx-sync-clock = "tsync_pin";
> > + fsl,tx-timeslot = <0xfffffffe>;
> > + fsl,rx-timeslot = <0xfffffffe>;
> > + fsl,tdm-framer-type = "e1";
> > + fsl,tdm-mode = "normal";
> > + fsl,tdm-id = <0>;
> > + fsl,siram-entry-id = <0>;
> > + };
> > +
> > + serial: ucc@2200 {
> > + device_type = "serial";
> > + compatible = "ucc_uart";
> > + port-number = <1>;
> > + rx-clock-name = "brg2";
> > + tx-clock-name = "brg2";
> > + };
>
> Missing reg.
>
> -Scott
>
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev
