On Mon, Mar 31, 2014 at 5:02 PM, Nathan Fontenot <nf...@linux.vnet.ibm.com> wrote: > struct rtas_error_log { > - unsigned long version:8; /* Architectural version */ > - unsigned long severity:3; /* Severity level of error */ > - unsigned long disposition:2; /* Degree of recovery */ > - unsigned long extended:1; /* extended log present? */ > - unsigned long /* reserved */ :2; /* Reserved for future use */ > - unsigned long initiator:4; /* Initiator of event */ > - unsigned long target:4; /* Target of failed operation > */ > - unsigned long type:8; /* General event or error*/ > - unsigned long extended_log_length:32; /* length in bytes */ > - unsigned char buffer[1]; /* Start of extended log */ > + /* Byte 0 */ > + uint8_t version; /* Architectural version */ > + > + /* Byte 1 */ > + uint8_t severity; > + /* XXXXXXXX > + * XXX 3: Severity level of error > + * XX 2: Degree of recovery > + * X 1: Extended log present? > + * XX 2: Reserved > + */ > + > + /* Byte 2 */ > + uint8_t :8; > + /* XXXXXXXX > + * XXXX 4: Initiator of event > + * XXXX 4: Target of failed operation > + */ > + uint8_t type; /* General event or error*/ > + uint32_t extended_log_length; /* length in bytes */
Now the bitfields are gone, things like the above can become __be32, so we get extra type checking from sparse ("make C=1"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev