Hi Cody, On Thu, 22 May 2014 15:44:25 -0700 Cody P Schafer <c...@linux.vnet.ibm.com> wrote: > > if (ret) { > if (success_expected) > pr_err_ratelimited("hcall failed: %d %#x %#x %d => > 0x%lx (%ld) detail=0x%x failing ix=%x\n", > domain, offset, ix, lpar, > ret, ret, > - result_buffer.buf.detailed_rc, > - result_buffer.buf.failing_request_ix); > - return ret; > + result_buffer->buf.detailed_rc, > + result_buffer->buf.failing_request_ix); > + goto out_hcall; > } > > - *res = be64_to_cpu(result_buffer.result); > + *res = be64_to_cpu(result_buffer->result);
not a biggie, but this last bit could be (remove the goto out_hcall and teh label and then) } else { *res = be64_to_cpu(result_buffer->result); } > +out_hcall: > + kfree(result_buffer); > +out_resb: > + kfree(request_buffer); > +out_reqb: > return ret; > } > otherwise looks good to me. -- Cheers, Stephen Rothwell s...@canb.auug.org.au
signature.asc
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev