Hi On Mon, Sep 1, 2014 at 5:21 PM, Pranith Kumar <bobby.pr...@gmail.com> wrote: > Hi David, > > On Mon, Sep 1, 2014 at 7:33 AM, David Herrmann <dh.herrm...@gmail.com> wrote: >> >> Nice catch. We changed 'flags' from u64 to "unsigned int" in the last >> revision of the series. Patch looks good, but I'd prefer using >> "unsigned int" as type, instead of __u32. Just to be consistent with >> the syscall interface. The return type of F_GET_SEALS is actually >> "int" and the MSB is reserved for signed error codes, so you can >> savely use "int r = fcntl(fd, F_GET_SEALS, 0)" in >> mfd_assert_get_seals(). >> > > OK. Should I send a new patch with these changes or do you have one > line up already?
I'd appreciate if you can resend it. Btw., the original patch (wire up syscalls) can be applied unchanged. Thanks David _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
