> > + > > + /* We assume Macs have consecutive I2C bus numbers starting at 0 */ > > + while (adap) { > > + err = keywest_attach_adapter(adap); > > + if (!err) > > + break; > > + i2c_put_adapter(adap); > > + adap = i2c_get_adapter(++i); > > + } > > + > > return 0; > > What if adap is NULL in the last while loop? Isn't it supposed to > return an error?
True, we probably should have something like return adap ? 0 : -ENODEV; Thanks!
signature.asc
Description: Digital signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev