On Fri, Dec 12, 2014 at 08:58:19AM +1100, Gavin Shan wrote: >On Thu, Dec 11, 2014 at 03:29:01PM +0800, Wei Yang wrote: >>On Thu, Dec 11, 2014 at 09:40:30AM +1100, Gavin Shan wrote: >>>On Wed, Dec 10, 2014 at 10:29:37PM +0800, Wei Yang wrote: >>>>The M64 range information is missed, which would be helpful in debug. >>>> >>>>This patch print the M64 range information in the same format as M32. > >s/print/prints > >>>> >>>>Signed-off-by: Wei Yang <[email protected]> >>>>--- >>>> arch/powerpc/platforms/powernv/pci-ioda.c | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>>diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c >>>>b/arch/powerpc/platforms/powernv/pci-ioda.c >>>>index 21c8b4d..34f1a27 100644 >>>>--- a/arch/powerpc/platforms/powernv/pci-ioda.c >>>>+++ b/arch/powerpc/platforms/powernv/pci-ioda.c >>>>@@ -369,6 +369,9 @@ static void __init pnv_ioda_parse_m64_window(struct >>>>pnv_phb *phb) >>>> phb->ioda.m64_segsize = phb->ioda.m64_size / phb->ioda.total_pe; >>>> phb->ioda.m64_base = pci_addr; >>>> >>>>+ printk(KERN_INFO " MEM64 0x%016llx..0x%016llx -> 0x%016llx\n", >>>>+ res->start, res->end, pci_addr); >>>>+ >>> >>>Please output segment size if you think it's helpful as well. >> >>The M64 segment size is printed in pnv_pci_init_ioda_phb() line 2620. >> > >Yes, it has been printed separately. So the change looks good to me >after you replace "printk(KERN_INFO ...)" with pr_info. Could you please >send updated version and include following line if you want:
Sure, glad to. > >Reviewed-by: Gavin Shan <[email protected]> > >Thanks, >Gavin -- Richard Yang Help you, Help me _______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
