Re: [PATCH] Fix offset2lib issue for x86*, ARM*, PowerPC and MIPS

[Ingo Molnar]

* Hector Marco Gisbert <hecma...@upv.es> wrote:

> +unsigned long randomize_et_dyn(unsigned long base)
> +{
> +     unsigned long ret;
> +     if ((current->personality & ADDR_NO_RANDOMIZE) ||
> +             !(current->flags & PF_RANDOMIZE))
> +             return base;
> +     ret = base + mmap_rnd();
> +     return (ret > base) ? ret : base;
> +}

> +unsigned long randomize_et_dyn(unsigned long base)
> +{
> +     unsigned long ret;
> +     if ((current->personality & ADDR_NO_RANDOMIZE) ||
> +             !(current->flags & PF_RANDOMIZE))
> +             return base;
> +     ret = base + mmap_rnd();
> +     return (ret > base) ? ret : base;
> +}

> +unsigned long randomize_et_dyn(unsigned long base)
> +{
> +     unsigned long ret;
> +     if ((current->personality & ADDR_NO_RANDOMIZE) ||
> +             !(current->flags & PF_RANDOMIZE))
> +             return base;
> +     ret = base + brk_rnd();
> +     return (ret > base) ? ret : base;
> +}

> +unsigned long randomize_et_dyn(unsigned long base)
> +{
> +     unsigned long ret;
> +     if ((current->personality & ADDR_NO_RANDOMIZE) ||
> +             !(current->flags & PF_RANDOMIZE))
> +             return base;
> +     ret = base + mmap_rnd();
> +     return (ret > base) ? ret : base;
> +}

> +unsigned long randomize_et_dyn(unsigned long base)
> +{
> +     unsigned long ret;
> +     if ((current->personality & ADDR_NO_RANDOMIZE) ||
> +             !(current->flags & PF_RANDOMIZE))
> +             return base;
> +     ret = base + mmap_rnd();
> +     return (ret > base) ? ret : base;
> +}

That pointless repetition should be avoided.

Thanks,

        Ingo
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev